Stg #42

Merged

SluberskiHomeLab merged 7 commits from STG into main

2025-10-08 14:29:19 -05:00

SluberskiHomeLab commented

2025-10-08 14:26:42 -05:00

(Migrated from github.com)

No description provided.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-08 14:28:38 -05:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR implements a comprehensive alert system for DitDashDot with enhanced theme support and testing infrastructure. The changes add service monitoring capabilities with Discord webhook notifications, expand the theme system to 11 distinct themes with visual effects, and provide robust configuration management.

Adds complete alert system with webhook notifications, configurable thresholds, and pause functionality
Expands theme system from 4 to 11 themes including retro, matrix, nuclear, and accessibility options
Implements comprehensive testing and documentation for the new alert features

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test-alerts.js	Test script for validating alert API endpoints
src/themes/themeConfig.js	Centralized theme configuration with 11 comprehensive themes
src/themes/backgrounds.css	CSS animations and effects for advanced themes
src/components/config/ConfigurationPage.js	Alert management UI with settings, history, and controls
src/components/ServiceCard.js	Refactored to use centralized theme system
src/App.js	Enhanced theme application with CSS classes and alert notifications
server/migrations/005_add_alerts.sql	Database schema for alert system tables
server/index.js	Backend alert processing, webhook integration, and API endpoints
public/themes/backgrounds.css	Public CSS for theme background effects
migrations/005_add_alerts.sql	Duplicate migration file
TROUBLESHOOTING.md	Comprehensive troubleshooting guide for alert system
README.md	Updated documentation with new features
ALERTS.md	Complete setup and configuration guide for alerts

Comments suppressed due to low confidence (1)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR implements a comprehensive alert system for DitDashDot with enhanced theme support and testing infrastructure. The changes add service monitoring capabilities with Discord webhook notifications, expand the theme system to 11 distinct themes with visual effects, and provide robust configuration management. - Adds complete alert system with webhook notifications, configurable thresholds, and pause functionality - Expands theme system from 4 to 11 themes including retro, matrix, nuclear, and accessibility options - Implements comprehensive testing and documentation for the new alert features ### Reviewed Changes Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | test-alerts.js | Test script for validating alert API endpoints | | src/themes/themeConfig.js | Centralized theme configuration with 11 comprehensive themes | | src/themes/backgrounds.css | CSS animations and effects for advanced themes | | src/components/config/ConfigurationPage.js | Alert management UI with settings, history, and controls | | src/components/ServiceCard.js | Refactored to use centralized theme system | | src/App.js | Enhanced theme application with CSS classes and alert notifications | | server/migrations/005_add_alerts.sql | Database schema for alert system tables | | server/index.js | Backend alert processing, webhook integration, and API endpoints | | public/themes/backgrounds.css | Public CSS for theme background effects | | migrations/005_add_alerts.sql | Duplicate migration file | | TROUBLESHOOTING.md | Comprehensive troubleshooting guide for alert system | | README.md | Updated documentation with new features | | ALERTS.md | Complete setup and configuration guide for alerts | </details> <details> <summary>Comments suppressed due to low confidence (1)</summary> </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/SluberskiHomeLab/ditdashdot/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

src/App.js

The alert banner condition checks for mode !== \"service_mode\" but the theme configuration shows multiple service mode variants (service_mode_light, service_mode_dark). This will incorrectly show the warning banner for valid service mode themes. The condition should check if the current theme has service mode capabilities using the serviceColors property.

The alert banner condition checks for `mode !== \"service_mode\"` but the theme configuration shows multiple service mode variants (service_mode_light, service_mode_dark). This will incorrectly show the warning banner for valid service mode themes. The condition should check if the current theme has service mode capabilities using the `serviceColors` property.

src/components/config/ConfigurationPage.js

Hard-coded tab index 6 makes the code brittle to changes in tab order. Consider using named constants or calculating the index dynamically to improve maintainability when tabs are added or reordered.